This repository was archived by the owner on May 14, 2026. It is now read-only.
Repository navigation
Chore: fix cargo clippy warnings - #186
Open
funny0facer wants to merge 2 commits into
Open
funny0facer wants to merge 2 commits into
funny0facer wants to merge 2 commits into
Conversation
zesterer
approved these changes
Feb 5, 2026
Comment on lines
-26
to
-28
| // Use the deprecated spin_loop_hint() to ensure that we don't get | ||
| // a higher MSRV than we need to. | ||
| #[allow(deprecated)] |
Owner
There was a problem hiding this comment.
Have you checked that this no longer applies with our MSRV?
Contributor
Author
There was a problem hiding this comment.
I am not sure what you mean.
From our Cargo.toml: rust-version = "1.71"
hint::spin_loop() is in rust since 1.49.0 (https://doc.rust-lang.org/src/core/hint.rs.html#268-295) and spin_loop_hint() is deprecated since 1.51.0 (https://doc.rust-lang.org/src/core/sync/atomic.rs.html#4608-4613)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran cargo clippy and got some warnings. Those were removed with the first commit.
After that, I checked if there were any #[allow] sections. => Therefore I replaced the deprecated spin_loop with the newer upstream solution.