[kingpinXD]

Summary

• zetatool snapshot now refuses an export it can't fully account for. Delegation shares must add up per validator, both staking pools must match exactly (the same rule the SDK applies on genesis import), and distribution must be in zero-height state, with the module holding only the community pool. These are hard errors, so --supply-check=false doesn't turn them off.
• The summary now splits the remainder by category. The H17619782 mainnet export still passes, and its snapshot_db.csv comes out byte-identical (sha256 bd62b8bd…ecb93).

Part of #4646 (SNAP-01). Targets feat/snapshot-export (#4613), not main.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking correction needed in the flag documentation.

Findings

1.  The flag promises too much ▶

Fix with agent prompt

### Issue 1
contrib/snapshot/README.md:138-139
`--supply-check=false` no longer downgrades all four checks listed here. `finalize` now rejects a bank-balance/supply mismatch before the command writes output or reaches `runChecks`. Operators following this paragraph will get an error instead of diagnostic files. Update this paragraph and the acceptance list to name that hard error.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR adds hard checks before building the migration snapshot.

• Snapshot exports stop when staking or reward records do not add up.
• The snapshot shows what makes up its migration remainder.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Read bank, staking, and distribution] --> B[Check distribution rewards and balance]
  B --> C[Check delegation totals and staking pools]
  C --> D[Attribute balances and classify remainder]
  D --> E[Check supply and remainder categories]
  E --> F[Write CSV files]
  F --> G[Run optional output checks]
  G --> H[Print summary]

Loading

_{Reviews (1) · Last reviewed commit: "fix(zetatool): name a supply mismatch an..." · Reviewed by Greptile}

[usmaneth]

solid. the pool checks match what the sdk enforces on genesis import, and i walked the remainder categories against supply by hand - pools cancel against validator tokens + unbonding entries, so the backstop really is a backstop. lint red is just golangci timing out on the schema fetch, not the code.

[morde08]

One documentation issue remains, also flagged by Greptile. I found no additional correctness issues in the changed code. Validated the pool accounting against the pinned Cosmos SDK implementation and ran go test ./cmd/zetatool/snapshot ./cmd/zetatool/cli successfully. CI still has a missing-changelog failure and a lint schema-download timeout.