Skip to content

Version Packages - #3161

Merged
ryan-roemer merged 1 commit into
mainfrom
changeset-release/main
Nov 12, 2026
Merged

ryan-roemer merged 1 commit into
mainfrom
changeset-release/main

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

victory-core@38.1.0

Minor Changes

  • #3166 c47d8ca - The primitives Circle, Line, Path, Rect, Text and TSpan accept their element's SVG attributes in TypeScript, such as <Line x1={25} y1={270} />, <Path d="..." /> and <Circle cx={1} cy={2} r={3} /> (#3122). These worked at runtime but failed to type-check. Where a Victory prop shares a name with an SVG attribute (origin, role, style, id, tabIndex, rx, ...), Victory's type is kept; name, which the primitives don't write to the element, stays out. VictoryPrimitiveShapeProps takes an optional element type (VictoryPrimitiveShapeProps<SVGLineElement>). New exported types: TSpanProps (the props of TSpan) and VictoryPrimitiveSvgProps.

Patch Changes

  • #3165 3ba0908 - DataGetterPropType (the type of x, y, y0 and sortKey) accepts accessors that return a Date, such as x={(d) => new Date(d.date)}. These worked at runtime but failed to type-check (TS2769).

  • #3164 1e3997f - Fix type errors in published declarations under skipLibCheck: false. createContainer and makeCreateContainerFunction now have explicit return types (TS2344 before), with the same props as before. ErrorBar's props are ErrorBarProps instead of any (typeof ErrorBar.default, TS2339 before). Code that passed ErrorBar undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. Axis.getTicks returns number[] | string[] | Date[]: it returns Dates for date tickValues, which its inferred number[] | string[] left out (also VictoryAxis's inferred ticks).

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-area@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-axis@38.1.0

Patch Changes

  • #3164 1e3997f - Fix type errors in published declarations under skipLibCheck: false. createContainer and makeCreateContainerFunction now have explicit return types (TS2344 before), with the same props as before. ErrorBar's props are ErrorBarProps instead of any (typeof ErrorBar.default, TS2339 before). Code that passed ErrorBar undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. Axis.getTicks returns number[] | string[] | Date[]: it returns Dates for date tickValues, which its inferred number[] | string[] left out (also VictoryAxis's inferred ticks).

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-bar@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-box-plot@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-brush-container@38.1.0

Patch Changes

  • #3163 e1909f7 - Type declarations no longer reference lodash's types, which consumers don't have (@types/lodash isn't a dependency): they resolved to any, or failed with TS7016 under skipLibCheck: false. The throttled helper handlers (BrushHelpers.onGlobalMouseMove, onMouseMove, ZoomHelpers.onWheel, ...) are now typed with their call signature, cancel() and flush(), and VictorySharedEvents's getBaseProps/getBasePropsFromChildren return Record<string, any>.

victory-candlestick@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-canvas@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-create-container@38.1.0

Patch Changes

  • #3164 1e3997f - Fix type errors in published declarations under skipLibCheck: false. createContainer and makeCreateContainerFunction now have explicit return types (TS2344 before), with the same props as before. ErrorBar's props are ErrorBarProps instead of any (typeof ErrorBar.default, TS2339 before). Code that passed ErrorBar undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. Axis.getTicks returns number[] | string[] | Date[]: it returns Dates for date tickValues, which its inferred number[] | string[] left out (also VictoryAxis's inferred ticks).

victory-cursor-container@38.1.0

Patch Changes

  • #3163 e1909f7 - Type declarations no longer reference lodash's types, which consumers don't have (@types/lodash isn't a dependency): they resolved to any, or failed with TS7016 under skipLibCheck: false. The throttled helper handlers (BrushHelpers.onGlobalMouseMove, onMouseMove, ZoomHelpers.onWheel, ...) are now typed with their call signature, cancel() and flush(), and VictorySharedEvents's getBaseProps/getBasePropsFromChildren return Record<string, any>.

victory-errorbar@38.1.0

Patch Changes

  • #3164 1e3997f - Fix type errors in published declarations under skipLibCheck: false. createContainer and makeCreateContainerFunction now have explicit return types (TS2344 before), with the same props as before. ErrorBar's props are ErrorBarProps instead of any (typeof ErrorBar.default, TS2339 before). Code that passed ErrorBar undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. Axis.getTicks returns number[] | string[] | Date[]: it returns Dates for date tickValues, which its inferred number[] | string[] left out (also VictoryAxis's inferred ticks).

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-histogram@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-legend@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-line@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-pie@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-polar-axis@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-scatter@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-selection-container@38.1.0

Patch Changes

  • #3163 e1909f7 - Type declarations no longer reference lodash's types, which consumers don't have (@types/lodash isn't a dependency): they resolved to any, or failed with TS7016 under skipLibCheck: false. The throttled helper handlers (BrushHelpers.onGlobalMouseMove, onMouseMove, ZoomHelpers.onWheel, ...) are now typed with their call signature, cancel() and flush(), and VictorySharedEvents's getBaseProps/getBasePropsFromChildren return Record<string, any>.

victory-shared-events@38.1.0

Patch Changes

  • #3163 e1909f7 - Type declarations no longer reference lodash's types, which consumers don't have (@types/lodash isn't a dependency): they resolved to any, or failed with TS7016 under skipLibCheck: false. The throttled helper handlers (BrushHelpers.onGlobalMouseMove, onMouseMove, ZoomHelpers.onWheel, ...) are now typed with their call signature, cancel() and flush(), and VictorySharedEvents's getBaseProps/getBasePropsFromChildren return Record<string, any>.

victory-voronoi@38.1.0

Patch Changes

  • #3160 37c7a74 - Build type declarations with @types/react 19. Refs from useCanvasContext() (canvasRef) and useVictoryContainer() (localContainerRef) are now typed RefObject<HTMLCanvasElement | null> and RefObject<HTMLDivElement | null> (no change on @types/react 18; correct on 19). Inferred ReactElement return types of some render methods now use unknown props instead of any, and class component types no longer list the legacy refs property. Code type-checks the same on @types/react 18 and 19.

victory-voronoi-container@38.1.0

Patch Changes

  • #3163 e1909f7 - Type declarations no longer reference lodash's types, which consumers don't have (@types/lodash isn't a dependency): they resolved to any, or failed with TS7016 under skipLibCheck: false. The throttled helper handlers (BrushHelpers.onGlobalMouseMove, onMouseMove, ZoomHelpers.onWheel, ...) are now typed with their call signature, cancel() and flush(), and VictorySharedEvents's getBaseProps/getBasePropsFromChildren return Record<string, any>.

victory-zoom-container@38.1.0

Patch Changes

  • #3163 e1909f7 - Type declarations no longer reference lodash's types, which consumers don't have (@types/lodash isn't a dependency): they resolved to any, or failed with TS7016 under skipLibCheck: false. The throttled helper handlers (BrushHelpers.onGlobalMouseMove, onMouseMove, ZoomHelpers.onWheel, ...) are now typed with their call signature, cancel() and flush(), and VictorySharedEvents's getBaseProps/getBasePropsFromChildren return Record<string, any>.

victory@38.1.0

No changes in this release.

victory-brush-line@38.1.0

No changes in this release.

victory-chart@38.1.0

No changes in this release.

victory-group@38.1.0

No changes in this release.

victory-stack@38.1.0

No changes in this release.

victory-tooltip@38.1.0

No changes in this release.

victory-vendor@38.1.0

No changes in this release.

@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
victory Ready Ready Preview Nov 12, 2026 7:52pm UTC

Request Review

ryan-roemer
ryan-roemer previously approved these changes Nov 12, 2026
ryan-roemer added a commit that referenced this pull request Nov 12, 2026
…an't resolve it to 18 (#3167)

- Version Packages #3161 failed `test`: its lockfile refresh (`changeset
version && pnpm install --no-frozen-lockfile`) resolved every package's
auto-installed `react` peer to the website's 18.3.1, so package code
loaded React 18 while the root's test tooling used 19 (victory-tooltip:
"A React Element from an older version of React")
- The 28 packages with a `react` peer list `react: ^19.3.1` as a
devDependency (root's range), so the lockfile no longer depends on
resolution order
- Replayed the version script locally: before, 28 `react` entries flip
to 18.3.1 and victory-tooltip fails; after, only version specifiers
change and all tests pass
- CI's React 18 matrix still works (its `overrides` apply to
devDependencies too; checked 18.0.0 locally)
- devDependencies only, no changeset; AGENTS.md notes why
@github-actions
github-actions Bot force-pushed the changeset-release/main branch from d1d6da1 to b283863 Compare November 12, 2026 19:51
@ryan-roemer
ryan-roemer merged commit 561802b into main Nov 12, 2026
8 checks passed
@ryan-roemer
ryan-roemer deleted the changeset-release/main branch November 12, 2026 20:22

This branch was successfully deployed

1 active deployment
Preview — b2838632 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant