Skip to content

[uplift] feat: accept SVG attributes in primitive prop types (#3122) - #3166

Merged
ryan-roemer merged 2 commits into
mainfrom
feat/uplift-primitive-svg-props
Nov 12, 2026
Merged

ryan-roemer merged 2 commits into
mainfrom
feat/uplift-primitive-svg-props

Conversation

@ryan-roemer

@ryan-roemer ryan-roemer commented Nov 12, 2026 •

Copy link
Copy Markdown
Member
  • Circle, Line, Path, Rect, Text, TSpan props include their element's React.SVGProps; Victory's types win where names overlap
  • New exported types: VictoryPrimitiveSvgProps, TSpanProps; VictoryPrimitiveShapeProps<TElement = SVGElement>
  • Removes the @ts-expect-error in line.test.tsx (it also hid a wrapper: "svg" error)
  • Only victory-core declarations changed; minor changeset (release becomes 38.1.0)
  • Consumer JSX checked on @types/react 18 and 19; check and pack:check pass
  • SVG props leave out what getSvgProps drops (name), so the types match what reaches the DOM; VictoryPrimitiveSvgProps's TOwnProps defaults to object

Closes #3122

@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
victory Ready Ready Preview Nov 12, 2026 6:54pm UTC

Request Review

@ryan-roemer
ryan-roemer requested a balanced review from Copilot November 12, 2026 18:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 51e19a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
victory-core Minor
victory-area Minor
victory-axis Minor
victory-bar Minor
victory-box-plot Minor
victory-brush-container Minor
victory-brush-line Minor
victory-candlestick Minor
victory-canvas Minor
victory-chart Minor
victory-create-container Minor
victory-cursor-container Minor
victory-errorbar Minor
victory-group Minor
victory-histogram Minor
victory-legend Minor
victory-line Minor
victory-pie Minor
victory-polar-axis Minor
victory-scatter Minor
victory-selection-container Minor
victory-shared-events Minor
victory-stack Minor
victory-tooltip Minor
victory-voronoi-container Minor
victory-voronoi Minor
victory-zoom-container Minor
victory Minor
victory-vendor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryan-roemer
ryan-roemer merged commit c47d8ca into main Nov 12, 2026
8 checks passed
@ryan-roemer
ryan-roemer deleted the feat/uplift-primitive-svg-props branch November 12, 2026 19:08
@github-actions github-actions Bot mentioned this pull request Nov 12, 2026
ryan-roemer pushed a commit that referenced this pull request Nov 12, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## victory-core@38.1.0

### Minor Changes

- [#3166](#3166)
[`c47d8ca`](c47d8ca)
- The primitives `Circle`, `Line`, `Path`, `Rect`, `Text` and `TSpan`
accept their element's SVG attributes in TypeScript, such as `<Line
x1={25} y1={270} />`, `<Path d="..." />` and `<Circle cx={1} cy={2}
r={3} />`
([#3122](#3122)). These
worked at runtime but failed to type-check. Where a Victory prop shares
a name with an SVG attribute (`origin`, `role`, `style`, `id`,
`tabIndex`, `rx`, ...), Victory's type is kept; `name`, which the
primitives don't write to the element, stays out.
`VictoryPrimitiveShapeProps` takes an optional element type
(`VictoryPrimitiveShapeProps<SVGLineElement>`). New exported types:
`TSpanProps` (the props of `TSpan`) and `VictoryPrimitiveSvgProps`.

### Patch Changes

- [#3165](#3165)
[`3ba0908`](3ba0908)
- `DataGetterPropType` (the type of `x`, `y`, `y0` and `sortKey`)
accepts accessors that return a `Date`, such as `x={(d) => new
Date(d.date)}`. These worked at runtime but failed to type-check
(TS2769).

- [#3164](#3164)
[`1e3997f`](1e3997f)
- Fix type errors in published declarations under `skipLibCheck: false`.
`createContainer` and `makeCreateContainerFunction` now have explicit
return types (TS2344 before), with the same props as before.
`ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof
ErrorBar.default`, TS2339 before). Code that passed `ErrorBar`
undeclared props, or wrongly typed ones, compiled only because of this
and now fails to type-check. `Axis.getTicks` returns `number[] |
string[] | Date[]`: it returns `Date`s for date `tickValues`, which its
inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred
`ticks`).

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-area@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-axis@38.1.0

### Patch Changes

- [#3164](#3164)
[`1e3997f`](1e3997f)
- Fix type errors in published declarations under `skipLibCheck: false`.
`createContainer` and `makeCreateContainerFunction` now have explicit
return types (TS2344 before), with the same props as before.
`ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof
ErrorBar.default`, TS2339 before). Code that passed `ErrorBar`
undeclared props, or wrongly typed ones, compiled only because of this
and now fails to type-check. `Axis.getTicks` returns `number[] |
string[] | Date[]`: it returns `Date`s for date `tickValues`, which its
inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred
`ticks`).

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-bar@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-box-plot@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-brush-container@38.1.0

### Patch Changes

- [#3163](#3163)
[`e1909f7`](e1909f7)
- Type declarations no longer reference lodash's types, which consumers
don't have (`@types/lodash` isn't a dependency): they resolved to `any`,
or failed with TS7016 under `skipLibCheck: false`. The throttled helper
handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`,
`ZoomHelpers.onWheel`, ...) are now typed with their call signature,
`cancel()` and `flush()`, and `VictorySharedEvents`'s
`getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`.
## victory-candlestick@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-canvas@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-create-container@38.1.0

### Patch Changes

- [#3164](#3164)
[`1e3997f`](1e3997f)
- Fix type errors in published declarations under `skipLibCheck: false`.
`createContainer` and `makeCreateContainerFunction` now have explicit
return types (TS2344 before), with the same props as before.
`ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof
ErrorBar.default`, TS2339 before). Code that passed `ErrorBar`
undeclared props, or wrongly typed ones, compiled only because of this
and now fails to type-check. `Axis.getTicks` returns `number[] |
string[] | Date[]`: it returns `Date`s for date `tickValues`, which its
inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred
`ticks`).
## victory-cursor-container@38.1.0

### Patch Changes

- [#3163](#3163)
[`e1909f7`](e1909f7)
- Type declarations no longer reference lodash's types, which consumers
don't have (`@types/lodash` isn't a dependency): they resolved to `any`,
or failed with TS7016 under `skipLibCheck: false`. The throttled helper
handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`,
`ZoomHelpers.onWheel`, ...) are now typed with their call signature,
`cancel()` and `flush()`, and `VictorySharedEvents`'s
`getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`.
## victory-errorbar@38.1.0

### Patch Changes

- [#3164](#3164)
[`1e3997f`](1e3997f)
- Fix type errors in published declarations under `skipLibCheck: false`.
`createContainer` and `makeCreateContainerFunction` now have explicit
return types (TS2344 before), with the same props as before.
`ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof
ErrorBar.default`, TS2339 before). Code that passed `ErrorBar`
undeclared props, or wrongly typed ones, compiled only because of this
and now fails to type-check. `Axis.getTicks` returns `number[] |
string[] | Date[]`: it returns `Date`s for date `tickValues`, which its
inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred
`ticks`).

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-histogram@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-legend@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-line@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-pie@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-polar-axis@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-scatter@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-selection-container@38.1.0

### Patch Changes

- [#3163](#3163)
[`e1909f7`](e1909f7)
- Type declarations no longer reference lodash's types, which consumers
don't have (`@types/lodash` isn't a dependency): they resolved to `any`,
or failed with TS7016 under `skipLibCheck: false`. The throttled helper
handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`,
`ZoomHelpers.onWheel`, ...) are now typed with their call signature,
`cancel()` and `flush()`, and `VictorySharedEvents`'s
`getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`.
## victory-shared-events@38.1.0

### Patch Changes

- [#3163](#3163)
[`e1909f7`](e1909f7)
- Type declarations no longer reference lodash's types, which consumers
don't have (`@types/lodash` isn't a dependency): they resolved to `any`,
or failed with TS7016 under `skipLibCheck: false`. The throttled helper
handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`,
`ZoomHelpers.onWheel`, ...) are now typed with their call signature,
`cancel()` and `flush()`, and `VictorySharedEvents`'s
`getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`.
## victory-voronoi@38.1.0

### Patch Changes

- [#3160](#3160)
[`37c7a74`](37c7a74)
- Build type declarations with `@types/react` 19. Refs from
`useCanvasContext()` (`canvasRef`) and `useVictoryContainer()`
(`localContainerRef`) are now typed `RefObject<HTMLCanvasElement |
null>` and `RefObject<HTMLDivElement | null>` (no change on
`@types/react` 18; correct on 19). Inferred `ReactElement` return types
of some render methods now use `unknown` props instead of `any`, and
class component types no longer list the legacy `refs` property. Code
type-checks the same on `@types/react` 18 and 19.
## victory-voronoi-container@38.1.0

### Patch Changes

- [#3163](#3163)
[`e1909f7`](e1909f7)
- Type declarations no longer reference lodash's types, which consumers
don't have (`@types/lodash` isn't a dependency): they resolved to `any`,
or failed with TS7016 under `skipLibCheck: false`. The throttled helper
handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`,
`ZoomHelpers.onWheel`, ...) are now typed with their call signature,
`cancel()` and `flush()`, and `VictorySharedEvents`'s
`getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`.
## victory-zoom-container@38.1.0

### Patch Changes

- [#3163](#3163)
[`e1909f7`](e1909f7)
- Type declarations no longer reference lodash's types, which consumers
don't have (`@types/lodash` isn't a dependency): they resolved to `any`,
or failed with TS7016 under `skipLibCheck: false`. The throttled helper
handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`,
`ZoomHelpers.onWheel`, ...) are now typed with their call signature,
`cancel()` and `flush()`, and `VictorySharedEvents`'s
`getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`.
## victory@38.1.0

No changes in this release.
## victory-brush-line@38.1.0

No changes in this release.
## victory-chart@38.1.0

No changes in this release.
## victory-group@38.1.0

No changes in this release.
## victory-stack@38.1.0

No changes in this release.
## victory-tooltip@38.1.0

No changes in this release.
## victory-vendor@38.1.0

No changes in this release.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ryan-roemer ryan-roemer mentioned this pull request Nov 12, 2026

This branch was successfully deployed

1 active deployment
Preview — 51e19a0c Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Primitive prop types don't include SVG attributes (x1, d, cx, ...)

2 participants