Repository navigation
[uplift] feat: accept SVG attributes in primitive prop types (#3122) - #3166
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
🦋 Changeset detectedLatest commit: 51e19a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
ryan-roemer
pushed a commit
that referenced
this pull request
Nov 12, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## victory-core@38.1.0 ### Minor Changes - [#3166](#3166) [`c47d8ca`](c47d8ca) - The primitives `Circle`, `Line`, `Path`, `Rect`, `Text` and `TSpan` accept their element's SVG attributes in TypeScript, such as `<Line x1={25} y1={270} />`, `<Path d="..." />` and `<Circle cx={1} cy={2} r={3} />` ([#3122](#3122)). These worked at runtime but failed to type-check. Where a Victory prop shares a name with an SVG attribute (`origin`, `role`, `style`, `id`, `tabIndex`, `rx`, ...), Victory's type is kept; `name`, which the primitives don't write to the element, stays out. `VictoryPrimitiveShapeProps` takes an optional element type (`VictoryPrimitiveShapeProps<SVGLineElement>`). New exported types: `TSpanProps` (the props of `TSpan`) and `VictoryPrimitiveSvgProps`. ### Patch Changes - [#3165](#3165) [`3ba0908`](3ba0908) - `DataGetterPropType` (the type of `x`, `y`, `y0` and `sortKey`) accepts accessors that return a `Date`, such as `x={(d) => new Date(d.date)}`. These worked at runtime but failed to type-check (TS2769). - [#3164](#3164) [`1e3997f`](1e3997f) - Fix type errors in published declarations under `skipLibCheck: false`. `createContainer` and `makeCreateContainerFunction` now have explicit return types (TS2344 before), with the same props as before. `ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof ErrorBar.default`, TS2339 before). Code that passed `ErrorBar` undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. `Axis.getTicks` returns `number[] | string[] | Date[]`: it returns `Date`s for date `tickValues`, which its inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred `ticks`). - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-area@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-axis@38.1.0 ### Patch Changes - [#3164](#3164) [`1e3997f`](1e3997f) - Fix type errors in published declarations under `skipLibCheck: false`. `createContainer` and `makeCreateContainerFunction` now have explicit return types (TS2344 before), with the same props as before. `ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof ErrorBar.default`, TS2339 before). Code that passed `ErrorBar` undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. `Axis.getTicks` returns `number[] | string[] | Date[]`: it returns `Date`s for date `tickValues`, which its inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred `ticks`). - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-bar@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-box-plot@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-brush-container@38.1.0 ### Patch Changes - [#3163](#3163) [`e1909f7`](e1909f7) - Type declarations no longer reference lodash's types, which consumers don't have (`@types/lodash` isn't a dependency): they resolved to `any`, or failed with TS7016 under `skipLibCheck: false`. The throttled helper handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`, `ZoomHelpers.onWheel`, ...) are now typed with their call signature, `cancel()` and `flush()`, and `VictorySharedEvents`'s `getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`. ## victory-candlestick@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-canvas@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-create-container@38.1.0 ### Patch Changes - [#3164](#3164) [`1e3997f`](1e3997f) - Fix type errors in published declarations under `skipLibCheck: false`. `createContainer` and `makeCreateContainerFunction` now have explicit return types (TS2344 before), with the same props as before. `ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof ErrorBar.default`, TS2339 before). Code that passed `ErrorBar` undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. `Axis.getTicks` returns `number[] | string[] | Date[]`: it returns `Date`s for date `tickValues`, which its inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred `ticks`). ## victory-cursor-container@38.1.0 ### Patch Changes - [#3163](#3163) [`e1909f7`](e1909f7) - Type declarations no longer reference lodash's types, which consumers don't have (`@types/lodash` isn't a dependency): they resolved to `any`, or failed with TS7016 under `skipLibCheck: false`. The throttled helper handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`, `ZoomHelpers.onWheel`, ...) are now typed with their call signature, `cancel()` and `flush()`, and `VictorySharedEvents`'s `getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`. ## victory-errorbar@38.1.0 ### Patch Changes - [#3164](#3164) [`1e3997f`](1e3997f) - Fix type errors in published declarations under `skipLibCheck: false`. `createContainer` and `makeCreateContainerFunction` now have explicit return types (TS2344 before), with the same props as before. `ErrorBar`'s props are `ErrorBarProps` instead of `any` (`typeof ErrorBar.default`, TS2339 before). Code that passed `ErrorBar` undeclared props, or wrongly typed ones, compiled only because of this and now fails to type-check. `Axis.getTicks` returns `number[] | string[] | Date[]`: it returns `Date`s for date `tickValues`, which its inferred `number[] | string[]` left out (also `VictoryAxis`'s inferred `ticks`). - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-histogram@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-legend@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-line@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-pie@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-polar-axis@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-scatter@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-selection-container@38.1.0 ### Patch Changes - [#3163](#3163) [`e1909f7`](e1909f7) - Type declarations no longer reference lodash's types, which consumers don't have (`@types/lodash` isn't a dependency): they resolved to `any`, or failed with TS7016 under `skipLibCheck: false`. The throttled helper handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`, `ZoomHelpers.onWheel`, ...) are now typed with their call signature, `cancel()` and `flush()`, and `VictorySharedEvents`'s `getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`. ## victory-shared-events@38.1.0 ### Patch Changes - [#3163](#3163) [`e1909f7`](e1909f7) - Type declarations no longer reference lodash's types, which consumers don't have (`@types/lodash` isn't a dependency): they resolved to `any`, or failed with TS7016 under `skipLibCheck: false`. The throttled helper handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`, `ZoomHelpers.onWheel`, ...) are now typed with their call signature, `cancel()` and `flush()`, and `VictorySharedEvents`'s `getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`. ## victory-voronoi@38.1.0 ### Patch Changes - [#3160](#3160) [`37c7a74`](37c7a74) - Build type declarations with `@types/react` 19. Refs from `useCanvasContext()` (`canvasRef`) and `useVictoryContainer()` (`localContainerRef`) are now typed `RefObject<HTMLCanvasElement | null>` and `RefObject<HTMLDivElement | null>` (no change on `@types/react` 18; correct on 19). Inferred `ReactElement` return types of some render methods now use `unknown` props instead of `any`, and class component types no longer list the legacy `refs` property. Code type-checks the same on `@types/react` 18 and 19. ## victory-voronoi-container@38.1.0 ### Patch Changes - [#3163](#3163) [`e1909f7`](e1909f7) - Type declarations no longer reference lodash's types, which consumers don't have (`@types/lodash` isn't a dependency): they resolved to `any`, or failed with TS7016 under `skipLibCheck: false`. The throttled helper handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`, `ZoomHelpers.onWheel`, ...) are now typed with their call signature, `cancel()` and `flush()`, and `VictorySharedEvents`'s `getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`. ## victory-zoom-container@38.1.0 ### Patch Changes - [#3163](#3163) [`e1909f7`](e1909f7) - Type declarations no longer reference lodash's types, which consumers don't have (`@types/lodash` isn't a dependency): they resolved to `any`, or failed with TS7016 under `skipLibCheck: false`. The throttled helper handlers (`BrushHelpers.onGlobalMouseMove`, `onMouseMove`, `ZoomHelpers.onWheel`, ...) are now typed with their call signature, `cancel()` and `flush()`, and `VictorySharedEvents`'s `getBaseProps`/`getBasePropsFromChildren` return `Record<string, any>`. ## victory@38.1.0 No changes in this release. ## victory-brush-line@38.1.0 No changes in this release. ## victory-chart@38.1.0 No changes in this release. ## victory-group@38.1.0 No changes in this release. ## victory-stack@38.1.0 No changes in this release. ## victory-tooltip@38.1.0 No changes in this release. ## victory-vendor@38.1.0 No changes in this release. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Open
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circle,Line,Path,Rect,Text,TSpanprops include their element'sReact.SVGProps; Victory's types win where names overlapVictoryPrimitiveSvgProps,TSpanProps;VictoryPrimitiveShapeProps<TElement = SVGElement>@ts-expect-errorinline.test.tsx(it also hid awrapper: "svg"error)@types/react18 and 19;checkandpack:checkpassgetSvgPropsdrops (name), so the types match what reaches the DOM;VictoryPrimitiveSvgProps'sTOwnPropsdefaults toobjectCloses #3122