Repository navigation
Return import rows as objects - #22
Merged
Merged
Conversation
martialblog
reviewed
Oct 28, 2026
martialblog
requested changes
Nov 9, 2026
martialblog
left a comment
martialblog
left a comment
Member
There was a problem hiding this comment.
I had a look at the original report and I think what we see might be a symptom not the cause of the actual error
What I think is going is, the request fails and then response is empty and thus there are not object.
The module always has returned assoc. arrays.
martialblog
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v0.5.0 (#18, use sysparm_display_value), fetchData() returns rows as associative arrays. The Director expects every row to be an object as soon as property modifiers are applied, so import sources with modifiers fail with:
Every imported row MUST be an object (ImportSource.php:312)
In v0.4.0 the rows were still objects (json_decode without assoc).
This casts each row to an object before returning it to the Director. Nested values stay arrays, which the Director handles as regular property values.