Skip to content

Return import rows as objects #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martialblog merged 2 commits into from
Nov 12, 2026
Merged

Return import rows as objects #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45a1d3
Return import rows as objects
Saeid-Abadi Oct 27, 2026
c59b5f1
[squash]
martialblog Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions library/Servicenowimport/ProvidedHook/Director/ImportSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ private function getRecordsFromTable(): array
$auth
);

$result = $client->request(
$resp = $client->request(
$endpoint,
[
'query' => [
Expand All @@ -271,28 +271,20 @@ private function getRecordsFromTable(): array
]
);

$data = Json::decode($result, true);
$data = Json::decode($resp);

$result = $this->extractDisplayValues($data['result'] ?? []);

return $result;
}

/*
* extractDisplayValues returns a copy of the given array but with
* the with display_value as the values instead of objects.
* We use sysparm_display_value the expand the ServiceNow objects.
* each object will have the actual value in the field display_value.
*/
protected function extractDisplayValues(array $array): array
{
return array_map(function ($value) {
if (!is_array($value)) {
return $value;
// We use sysparm_display_value the expand the ServiceNow objects.
// each object will have the actual value in the field display_value.
// Note, we need to return an array of stdclass objects.
foreach ($data->result as $row) {
foreach (get_object_vars($row) as $key => $value) {
if (is_object($value) && property_exists($value, 'display_value')) {
$row->$key = $value->display_value;
}
}
}

return array_key_exists('display_value', $value) ? $value['display_value'] : $this->extractDisplayValues($value);
}, $array);
return $data->result;
}

protected static function addProxy(QuickForm $form)
Expand Down