Repository navigation
Conversation
…itial build_transmission script using Delaunay and Gabriel filtering.
…) to transmission key.
…nstead of carriers.
…rojects_and_dlr and build_transmission projects for clarity.
…ions [][efficiency] respectively.
…the gas distribution grid, only capital costs. Clean-up.
Keep the Delaunay/Gabriel candidate topology for new H2 and CO2 pipelines, configured by the additive key sector: pipeline_topology. Revert the restructure of lines, links, transformers, transmission_projects and the sector network keys into a new transmission section.
Add the two rules to the rules overview, update the hydrogen and carbon management design pages and add a release note. Rewrite the module docstrings to the template of the rules pages.
Test Gabriel edges with a k-d tree query of the edge midpoints instead of a dense distance matrix, extract Delaunay edges with numpy, simplify the min-degree backfill and merge the Delaunay and filter rules. Results are identical for 5 to 4125 buses. Add references for the Gabriel graph and k-d tree.
4 of 5 tasks
bobbyxng
reviewed
Nov 3, 2026
bobbyxng
left a comment
bobbyxng
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @fneum for porting over the code and improving the speed!
I tested the workflow on a few networks, and the results seem identical to the old PR, only that its much faster :)
Apart from the comments in the code, I have a few comments, tbd.:
- Before, we allowed carrier-individual settings for
min_degree,max_offshore_distance, it's fine by me to simplify, but I also think it wouldn't hurt to allow the differentiation - Gas routes are no longer explicit candidates for H2 (retrofit is not affected), but should we allow the option for H2 pipelines to superposition the gas grid?
- Biomass transport still uses electricity grid topology, should we harmonise it here as well and treat it the same way as CO2 and H2?
- What about AC/DC? Do we want to explicitly allow new corridors there or only allow increase in capacities (master)?
- Consider a small unit tests using square, triangle, two points, colinear points so we cover these strange/failing degenerate cases (which are currently fine in the master)
…elaunay # Conflicts: # doc/release_notes.md
- sector: transport_corridors sets min_degree and max_offshore_distance separately for H2, CO2 and biomass; one rule, one file, one boolean column per carrier - biomass transport uses the Delaunay corridors in both directions - new H2 pipelines can also follow existing gas pipelines - triangulate with Qhull QJ so collinear and coincident buses keep their corridors; up to three buses are connected pairwise - consider AC buses only and list buses below the minimum degree - unit tests for degenerate layouts and carrier-specific settings - shorter release note, method described in the design docs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fneum
commented
Nov 3, 2026
fneum
left a comment
fneum
left a comment
Member
Author
There was a problem hiding this comment.
Alright, thanks for the feedback! I implemented most of your suggestions. Ready to go?
| scripts("cluster_gas_network.py") | ||
|
|
||
|
|
||
| rule build_transmission_topology: |
Member
Author
There was a problem hiding this comment.
should work, they just need to put it under run: shared_resources: exclude
Collaborator
Thanks @fneum, looks good to me! One last thing before merging: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2153 by @bobbyxng (original commits retained). Closes #2151.
Candidate corridors for new H2 and CO2 pipelines now come from a Delaunay triangulation of the regions, reduced by default to the Gabriel graph with at least one candidate per region, instead of the electricity grid topology.
Compared to #2153:
transmissionsection is dropped to avoid breaking changes. All existing keys are unchanged. The only new option issector: pipeline_topology(min_degree,max_offshore_distance). Pipeline lengths uselines: length_factor.build_transmission_topology) instead of two. The Gabriel test uses a k-d tree query of the edge midpoints instead of a dense distance matrix (about 500 to 180 lines).Equivalence with the #2153 implementation: identical Delaunay graphs (edges, lengths, Gabriel flags, offshore shares, geometries) and identical candidate sets for
min_degree0 to 3 andmax_offshore_distanceunlimited and 300 km, on networks with 5, 52, 100, 128 and 4125 buses.This changes default results (see release note). For example, long direct offshore corridors such as Norway to Germany are not in the Delaunay graph; Norway stays connected across the North Sea via Scotland and Denmark.