Repository navigation
Conversation
giunatale
requested review from
clockworkgr,
julienrbrt and
tbruyelle
as code owners
November 11, 2026 16:22
giunatale
force-pushed
the
giunatale/test/lifecycle-suite
branch
2 times, most recently
from
November 12, 2026 14:54
23c0914 to
691a9b7
Compare
…pers to the base e2e suite, with height-aware variants and a split proposal helper
…op, stopped sweep, deletion and pre-launch removal
…longer need it do not
…with the auto-stop bonding its own silent validator
…20 minutes, and correct the suite's timing notes The suite took the host ports of the four-validator suite; it now sits at 27057/9490/1717/27056 and 27067/9492/1727/27066. The parameter rationale states that the lapse scenario needs blocks averaging under 1.5s, the README the four downtime windows per epoch the withheld record's determinism rests on, the measured run time, and the test-e2e target by name.
…nd assert the thaw exactly The still-paused checks at the thaw's original maturity read the first block at or past that maturity, and the frozen record is read at the last paused block once the auto-stop has landed, so neither depends on how fast the queries return. The thaw moves executes_at by exactly the pause's block-time span, which the scenario now asserts with equality.
…proposal id that parses unbondFrom polled query tx twice, once to require the commit and once for the height; requireTxCommitted now returns the height it already reads, and mustTxHeight goes. extractProposalID returns the first submit_proposal.proposal_id attribute that parses as a number instead of giving up on the first one found.
…and the removal verdict, end to end During the auto-stop's pause an equivocating validator's double vote is accepted and queues a punishment whose clock starts at the pause; the lapse moves it to exactly one delay after the stop, and it executes in the first block at or past that time, since a lapsed pause is not a verdict. A new scenario then has a second validator's double vote accepted against the STOPPED consumer, passes a governance MsgRemoveConsumer against it, which cancels that punishment in its tally block with vaas_remove_consumer reporting phase STOPPED, and finds fresh evidence refused. It runs inside the wait for the deletion, whose time is still counted from the auto-stop.
…rs carry the one-consumer directive
…and let the polling conditions retry The lapse scenario requires the withheld record to stand at the boundary after the silent validator left, 60 blocks past the boundary that last withheld, while the record expires one challenge window after that boundary's block time: at 90s the two met at 1.5s per block. The window and the evidence max age it also sets are 120s, so blocks may average under 2s over that epoch. The challenge horizon is then 240s, and the declared consumer client's trusting period (two thirds of the consumer's unbonding, which may not exceed the provider's) must exceed it, so both unbondings are 400s; the header comment re-derives every clock that follows from them and the README carries the longer run. The auto-stop watch no longer counts a failed phase query, which reads back "", as the consumer leaving the pause. The waits on a validator's tokens and bond status and on a pending punishment poll through error-returning helpers (tryProviderValidator, tryValidatorTokens, queryPendingEquivocations), so a transient query failure retries at the next tick instead of stalling the wait to its timeout.
giunatale
force-pushed
the
giunatale/test/lifecycle-suite
branch
from
November 13, 2026 17:46
691a9b7 to
1b6e0bc
Compare
…n the lifecycle suite
Contributor
Author
|
Rebase checklist, from a local merge of the open PRs in the planned order (this branch lands after #90, #99 and #115):
|
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves #86's thaw and #98's evidence rules end to end; the rest of the suite proves behaviour of main that had unit or app-level tests only.
A third suite,
TestLifecycleIntegrationTestSuite, on its own ports (the +400 block, 27057 and up) and chain ids, with a short provider unbonding period (300 s), a shortmax_pause_duration(150 s), 60-block epochs and a 90 s downtime challenge window, so that every clock the lifecycle runs on elapses inside the run. Nine scenarios, in the order the state allows:executes_at. The bonded validator's refusal pauses the consumer; in the first block at or past the original maturity (read at that height) the entry is still pending and untouched; the refusal is withdrawn and governance resumes. The suite reads the pause and resume times from the chain (the first block in each phase) and assertsexecutes_atmoved by exactly that span, then that the entry executes in the first block at or past the moved time: the execution event, the tombstone, the slash.vaas_withheld_fee_paidevent in that block, the validator's fee balance at its baseline, the pool unchanged across the block. Those accusations then mature and execute against the unbonding entry, which reads slashed, and the record stays gone.max_pause_durationstops the consumer. A third silent validator bonds first, so a record is live when the pause begins; paused again by refusal, with that record frozen in place (read at the last paused block); double-voting evidence submitted during the pause is accepted and queues a punishment whose clock starts at the pause; the consumer never leaves the pause early and is STOPPED in the first block at or past the deadline, the punishment moved to exactly one delay after the stop; the pending accusations are cancelled, the record lapses and is swept with nothing paid, and a resume proposal fails.MsgRemoveConsumerproposal against it passes and cancels that punishment in its tally block, which reportsvaas_remove_consumerwith phase STOPPED; fresh evidence is then refused. It runs inside the wait for the deletion.make test-e2eruns the three suites in sequence, about 75 minutes, so its timeout goes from 60 to 120 minutes, leaving room for the scenarios other open PRs add; the suite joins #90's CI matrix when it rebases onto it.Harness: the refusal, resume-proposal, fee pool, withheld-record and validator-address helpers move from the main suite to the base suite, with height-aware variants, the proposal helper splits into submit-and-vote and wait-for-status, the pending-downtime-slash and unbonding-entry queries get height-aware variants, and
requireTxCommittedreturns the height its transaction landed at, which the undelegation helper passes on;extractProposalIDtakes the firstproposal_idthat parses. The suite's chain-data helpers (block times, first height in a phase, block events) sit with it.The suite's clocks were widened after its first runs: the downtime challenge window and evidence max age are 120 s over a 400 s unbonding on both chains, so the relayer-derived trusting period (two thirds, about 265 s) clears the 240 s horizon and the lapse scenario keeps a 30 s margin at 1.5 s per block. The auto-stop watch reads a failed phase query as "no change", and the polling conditions use error-returning helpers so a transient query failure retries instead of stalling to the timeout. The suite takes about 30 minutes.