Repository navigation
Conversation
giunatale
requested review from
clockworkgr,
julienrbrt and
tbruyelle
as code owners
November 13, 2026 18:11
… the refusal watch testify runs the condition of Eventually and Never in a goroutine of its own, so a helper that fails the test from inside one stalls the wait to its timeout: the revision bump's 12-minute wait for the declared client to expire, its waits on the next send sequence and on val2's second punishment, the fork drill's wait on the recovered client's height, and the fabricated double-sign's wait on val2's jail. Each helper polled there has an error-returning twin now (tryClientStatus, tryClientLatestHeight, tryNextSequenceSend, tryPendingEquivocationsOf, tryStakingValidatorState), modelled on tryProviderValidatorConsAddr, and the conditions use the twins. The refusal scenario's Never watch read a failed phase query, which the phase helper reports as an empty phase, as the consumer leaving LAUNCHED; it ignores the empty phase now.
…ario With near-equal powers, val0 then val1 refusing sat at a quarter and a half of the bonded power, the shares one of four and two of four validators are under head counting as well, so a threshold that counted validators passed both assertions. val0 now self-delegates 2100 power first, to 3100 of 6190, half of the bonded power; val2 and val3 refuse together, two of four with 1990, under the one-third threshold, and the consumer stays launched; they withdraw and val0 refuses alone, one of four with half, and the consumer pauses. The scenario reads both shares from the provider's consensus set and requires them on their sides of the threshold before acting, so a change in the earlier scenarios' powers fails it with the numbers. val0's node is never stopped afterwards, and the outages the later scenarios take leave over four fifths of the power online.
…wo revision bump clauses prove The fork drill compared jail, stake and tombstone before and after the recovery but never read when val2's deferred punishment executes, so a resume that moved it wrongly passed. The fork scenario records the maturity before the fork and the time of the block the misbehaviour message paused the consumer in (the pause lands in the message's own block); the drill requires the maturity unchanged by the pause and by the refused resume, and moved by exactly the pause, resume block time minus pause block time, once the recover-and-resume proposal passes. The provider block time comes from providerBlockTime on the base suite, the resume block from the resumed event in the provider's block results. Two clauses of the revision bump drill were true for the wrong reason: the accusation check reads a queue that was empty before the recovery, and the liveness sweep could not act in the watched window with the suite's grace of two thirds of a 21-day unbonding period. Their comments and messages now say what they prove: no accusation pending across the pause, and the mismatch check not acting on the paused consumer again.
…e a suite comes up The stale cleanup removed the named node, init and relayer containers of a previous run and ignored the error of removing its network. A scenario's ephemeral export or validate container, purged by a defer, outlives a run killed while it ran, docker refuses to remove the network it is attached to, and the name stays taken, so the next setup failed at the network's creation. The cleanup now inspects the network, force-removes every container still attached to it, removes the network, and fails the suite with docker's reason if that removal fails for any reason but the network being gone.
go build in tests/e2e/forge writes a 150 MB forge binary next to its sources; the repository must never carry it.
…n the four-validator and forge suites
giunatale
force-pushed
the
giunatale/test/harden-four-validator-suites
branch
from
November 13, 2026 18:42
8353b7c to
9e37dcf
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #115 to keep one stack; what it hardens is the four-validator and forge suites of #90, #91, #104, #114 and #115. It merges after #98: the fork drill's exact check on the punishment maturity across the pause needs the resume thaw #98 carries.
go buildwrites in the forge module is ignored.