Repository navigation
Update emsdk version from ee1f7ce8 to eb132757 - #28027
Merged
Merged
Conversation
This is an automatic change generated by tools/maint/rebaseline_tests.py --update-emsdk. emsdk version updated: ee1f7ce8 => eb132757 The following revisions were included in this update: ``` - eb132757 Version 6.0.13 RC ``` Full log: https://chromium.googlesource.com/emscripten-releases/+log/ee1f7ce8..eb132757 The following (2) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_cxx_lto.json: 119499 => 119516 [+17 bytes / +0.01%] codesize/test_codesize_cxx_mangle.json: 265550 => 265557 [+7 bytes / +0.00%] Average change: +0.01% (+0.00% - +0.01%) ```
emscripten-bot
enabled auto-merge (squash)
October 20, 2026 10:44
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Emscripten SDK version hash in test/emsdk_version.txt and adjusts the expected code sizes in test/codesize/test_codesize_cxx_lto.json and test/codesize/test_codesize_cxx_mangle.json accordingly. There are no review comments, and I have no feedback to provide.
sbc100
approved these changes
Oct 20, 2026
sbc100
disabled auto-merge
October 20, 2026 15:59
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 20, 2026
When a release candidate commit in `emscripten-releases` modifies `DEPS.tagged-release`, the waterfall builds that revision using `DEPS.tagged-release` (which may be branched from an older revision) rather than `DEPS`. - Teach `tools/maint/sync_deps.py` to fetch `DEPS.tagged-release` when the target `emscripten-releases` revision modifies that file, matching what the corresponding prebuilt `emsdk` archive was built from. - Teach `tools/maint/rebaseline_tests.py --update-emsdk` to skip commits that modify `DEPS.tagged-release` so that `test/emsdk_version.txt` does not roll backwards to an older RC snapshot (as happened in emscripten-core#28027).
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Oct 20, 2026
…1812) Commits in `emscripten-releases` that modify `DEPS.tagged-release` are release candidates whose dependencies are often branched from an older revision than tip-of-tree `DEPS`. Exclude commits that only modify `DEPS.tagged-release` when finding the latest `tot` build. This recently bit us, resulting in a tagged release being rolled into emscripten: emscripten-core/emscripten#28027.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic change generated by tools/maint/rebaseline_tests.py --update-emsdk.
emsdk version updated: ee1f7ce8 => eb132757
The following revisions were included in this update:
Full log: https://chromium.googlesource.com/emscripten-releases/+log/ee1f7ce8..eb132757
The following (2) test expectation files were updated by
running the tests with
--rebaseline: