Repository navigation
Conversation
This was referenced Oct 16, 2026
jtmcdole
requested changes
Oct 19, 2026
Member
There was a problem hiding this comment.
... I feel like I've seen this before... stacked prs == good
Collaborator
Author
There was a problem hiding this comment.
We chatted about this on Friday - you told me not to go stacked! 🤣
Based off of #6 - should be reviewed first
| @@ -0,0 +1,288 @@ | |||
| import 'dart:io'; | |||
Member
There was a problem hiding this comment.
channeling my inner zach: copyright headers
jtmcdole
reviewed
Oct 19, 2026
Comment on lines
+152
to
+162
| buffer.writeln('## Weekly review period status update'); | ||
| buffer.writeln(); | ||
| buffer.writeln( | ||
| '**$title** is currently in the 30-day review and grace period:'); | ||
| buffer.writeln('- **Elapsed:** $daysElapsed day(s) (opened $createdDate)'); | ||
| buffer.writeln( | ||
| '- **Remaining:** $daysRemaining day(s) until the 30-day review window concludes on **$targetEndDate**'); | ||
| buffer.writeln(); | ||
| buffer.writeln( | ||
| 'If you were tagged above and have not yet replied, please comment on this thread before **$targetEndDate** to accept your invitation, share your Discord username for team member role provisioning, or share qualitative contributions (issue triage, reproductions, [RFCs](https://github.com/flutter/rfc), design docs, or mentoring).'); | ||
| return buffer.toString(); |
Member
There was a problem hiding this comment.
return '''
## Weekly review period status update
**$title** is currently in the 30-day review and grace period:
- **Elapsed:** $daysElapsed day(s) (opened $createdDate)
- **Remaining:** $daysRemaining day(s) until the 30-day review window concludes on **$targetEndDate**
If you were tagged above and have not yet replied, please comment on this thread before **$targetEndDate** to accept your invitation, share your Discord username for team member role provisioning, or share qualitative contributions (issue triage, reproductions, [RFCs](https://github.com/flutter/rfc), design docs, or mentoring).
''';
Comment on lines
+178
to
+191
| buffer.writeln('## 30-day review period concluded'); | ||
| buffer.writeln(); | ||
| buffer.writeln( | ||
| 'cc $mentions — The 30-day review and grace period for **$title** has concluded ($daysElapsed days since opening).'); | ||
| buffer.writeln(); | ||
| buffer.writeln('### Next steps:'); | ||
| buffer.writeln( | ||
| '1. Review qualitative contributions, appeals, and Discord usernames shared by new joiners/promoted members in this thread.'); | ||
| buffer.writeln( | ||
| '2. On the open quarterly review PR branch, run `dart run tool/quarterly_audit.dart --finalize --retain ... --exclude ... --discord user=handle` to update `data/contributors.yaml`, [ROSTER.md](ROSTER.md), and [EMERITUS.md](EMERITUS.md), then merge the PR.'); | ||
| buffer.writeln( | ||
| '3. Update GitHub teams (`@flutter/reviewers`, `@flutter/committers`, and `@flutter/maintainers` as child teams of `@flutter/flutter-hackers`, along with `@flutter/partners` child teams), grant the Discord team member role to newly added ladder members, and remove members transitioning to Dasher Emeritus from the GitHub organization.'); | ||
| buffer.writeln('4. Close this issue once updates land.'); | ||
| return buffer.toString(); |
| } | ||
|
|
||
| /// Posts a comment to a GitHub issue. | ||
| Future<void> postIssueComment(int issueNumber, String body) async { |
Member
There was a problem hiding this comment.
should we steal ProcessRunner from somewhere so these could be tested?
| } | ||
| } | ||
|
|
||
| ({String? role, String? discord}) findUserInfo(YamlMap doc, String username) { |
Member
There was a problem hiding this comment.
You could use JsonSerializable to handle parsing the yaml, or a final class rather than juggling YamlMap / YamlList everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #6 - should be reviewed first
Part 3 of 4
Full Picture: #3
Towards flutter/flutter#186415
RFC: flutter/rfc#36
Adds the automated quarterly review audit pipeline, 30-day grace period tracker, and supporting CLI/agent tooling:
tool/quarterly_audit.dartand.github/workflows/quarterly_review.ymlto run quarterly community and partner team audits, generate reports, open tracking issues, and finalize roster updates (--finalize).tool/check_grace_period.dartand.github/workflows/check_grace_period.ymlto post weekly countdown updates during the 30-day review window and notify the assignee when the grace period concludes.tool/check_user.dartfor single-user qualification checks, comprehensive unit tests intest/quarterly_audit_test.dart, and thequarterly-ladder-analysisagent skill.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.