Repository navigation
feat: add toolbar with page navigation to pdf-viewer - #13281
Merged
Merged
Conversation
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
11 times, most recently
from
October 27, 2026 09:50
0ad2461 to
18432e5
Compare
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
2 times, most recently
from
October 27, 2026 10:05
a6dc1b8 to
684719f
Compare
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
from
October 27, 2026 10:22
684719f to
876b6d7
Compare
Contributor
Custom elements APICompared #13281 ( custom-elements.json impact: 1 added in 1 element@@ vaadin-pdf-viewer (PdfViewer) @@
+ property i18n: PdfViewerI18n | undefinedweb-types.json impact: 1 added in 1 element@@ vaadin-pdf-viewer @@
+ property i18n: PdfViewerI18n | undefined |
web-padawan
marked this pull request as ready for review
October 27, 2026 10:37
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 1 comment.
| Finding | |
|---|---|
Previous page button skips the last page when page is above pageCount |
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
2 times, most recently
from
October 27, 2026 11:46
18c4b35 to
9d6038f
Compare
vursen
reviewed
Oct 27, 2026
vursen
reviewed
Oct 27, 2026
Contributor
|
FIXED: Screen.Recording.2026-10-27.at.15.56.12.mov |
vursen
reviewed
Oct 27, 2026
Contributor
Member
Author
Fixed. Also added |
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
from
October 27, 2026 19:21
22841ae to
b206737
Compare
Contributor
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Other components, e.g. rich text editor and dashboard, have none. Themes set the private `--_icon` property of the button instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fixed width fit page counts up to 999. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
web-padawan
force-pushed
the
feat/pdf-viewer-toolbar-navigation
branch
from
October 28, 2026 06:51
b206737 to
64f0a51
Compare
vursen
reviewed
Oct 28, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Let's figure out how it should look like when adding Lumo / Aura. |
|
vursen
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
Part of #7669
accessibleDisabledButtonsfeature flagchangeandinputevents of the page field do not reach the applicationtoolbar-actionsslot for application controls at the end of the toolbar, in DOM ordervaadin-pdf-viewer-buttonwith an icon and a tooltip that shows its labeli18nproperty withI18nMixin, for the button tooltips (previousPage,nextPage) and the page error (pageError)DEFAULT_I18N, and the mixins read the texts from__effectiveI18n. Later PRs add their own texts to ittoolbarandtoolbar-groupparts and the--vaadin-pdf-viewer-toolbar-background,-toolbar-gapand-toolbar-paddingCSS properties--vaadin-field-default-width, which an application can set on the fieldZoom and the header come in the next two PRs. The toolbar, its buttons and the page field have no role or accessible names yet. They come with their
i18ntexts in the accessibility PR.Type of change
How to test
yarn startand opendev/pdf-viewer.html2 / 25in the page field and press Enter. The field turns invalid and shows "Enter 1–2"Different from prototype
DEFAULT_I18Nhas only the three texts that the toolbar uses. The prototype defined the texts of all features at once.pagethat is not an integer, instead of passing it tovaadin-integer-field, which logs a warning.--_iconproperty of the button.Improvements over prototype
pageabove the page count.Postponed
Explainer
https://claude.ai/artifact/MZwhUiy2Hbw2kSsYF1rC5M
🤖 Generated with Claude Code